Fixed a crash introduced in 2f568b8 (#2856) (#2871)

Chatterino · Jun 6, 2021 · 5512437 · 5512437
1 parent 2f568b8
commit 5512437
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/src/providers/IvrApi.cpp b/src/providers/IvrApi.cpp
@@ -37,8 +37,6 @@ void IvrApi::getBulkEmoteSets(QString emoteSetList,
                               ResultCallback<QJsonArray> successCallback,
                               IvrFailureCallback failureCallback)
 {
-    assert(!emoteSetList.isEmpty());
-
     QUrlQuery urlQuery;
     urlQuery.addQueryItem("set_id", emoteSetList);
 

diff --git a/src/providers/twitch/TwitchAccount.cpp b/src/providers/twitch/TwitchAccount.cpp
@@ -307,13 +307,16 @@ void TwitchAccount::loadUserstateEmotes(QStringList emoteSetKeys)
     constexpr int batchSize = 100;
 
     std::vector<QStringList> batches;
+    int batchCount = (newEmoteSetKeys.size() / batchSize) + 1;
 
-    batches.reserve((newEmoteSetKeys.size() + 1) / batchSize);
+    batches.reserve(batchCount);
 
-    for (int i = 0; i < newEmoteSetKeys.size(); i += batchSize)
+    for (int i = 0; i < batchCount; i++)
     {
         QStringList batch;
-        for (int j = batchSize * i; j < batchSize; j++)
+
+        int last = std::min(batchSize, newEmoteSetKeys.size() - batchSize * i);
+        for (int j = batchSize * i; j < last; j++)
         {
             batch.push_back(newEmoteSetKeys.at(j));
         }