Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PubSub creates only 1 connection, strictly limitting amount of topics Chatterino can listen to #3014

Closed
zneix opened this issue Jul 15, 2021 · 0 comments · Fixed by #3037
Closed
Assignees
Labels
bug Something isn't working as intended, or works in a confusing/unintuitive way for the user Feature: PubSub Issues related to our PubSub system, topic we listen to and things that use pubsub messages' content help wanted Help is wanted to debug/fix this issue needs testing

Comments

@zneix
Copy link
Collaborator

zneix commented Jul 15, 2021

As defined here, these are the limits of how many connections and listen requests can PubSub make:

#define MAX_PUBSUB_LISTENS 50
#define MAX_PUBSUB_CONNECTIONS 10

While those do comply with twitch docs, we don't scale connections to 10 at max (MAX_PUBSUB_CONNECTIONS isn't used anywhere), making it sometimes impossible to listen to certain topics.
As a proof to my previous statement, I've added a some code (git diff) to see how many times we actually try to listen to a PubSub topic:

debug popup

Note: 100 listen attempts instead of expected 50 might be caused due to following found by @Bun
thanks cbdg

@zneix zneix added bug Something isn't working as intended, or works in a confusing/unintuitive way for the user needs testing help wanted Help is wanted to debug/fix this issue Feature: PubSub Issues related to our PubSub system, topic we listen to and things that use pubsub messages' content labels Jul 15, 2021
@pajlada pajlada self-assigned this Jul 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working as intended, or works in a confusing/unintuitive way for the user Feature: PubSub Issues related to our PubSub system, topic we listen to and things that use pubsub messages' content help wanted Help is wanted to debug/fix this issue needs testing
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants