Added stream titles to windows toast notifications #2044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
23rd
reviewed
Oct 8, 2020
23rd
reviewed
Oct 8, 2020
Co-authored-by: 23rd <23rd@vivaldi.net>
Co-authored-by: 23rd <23rd@vivaldi.net>
pajlada
approved these changes
Oct 30, 2022
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -66,11 +66,12 @@ QString Toasts::findStringFromReaction( | |||
| return Toasts::findStringFromReaction(static_cast<ToastReaction>(i)); | |||
| } | |||
|
|
|||
| void Toasts::sendChannelNotification(const QString &channelName, Platform p) | |||
| void Toasts::sendChannelNotification(const QString &channelName, | |||
There was a problem hiding this comment.
warning: method 'sendChannelNotification' can be made static [readability-convert-member-functions-to-static]
src/singletons/Toasts.hpp:21:
- void sendChannelNotification(const QString &channelName,
+ static void sendChannelNotification(const QString &channelName,| @@ -66,11 +66,12 @@ | |||
| return Toasts::findStringFromReaction(static_cast<ToastReaction>(i)); | |||
| } | |||
|
|
|||
| void Toasts::sendChannelNotification(const QString &channelName, Platform p) | |||
| void Toasts::sendChannelNotification(const QString &channelName, | |||
| const QString &channelTitle, Platform p) | |||
There was a problem hiding this comment.
warning: parameter 'channelTitle' is unused [misc-unused-parameters]
Suggested change
| const QString &channelTitle, Platform p) | |
| const QString & /*channelTitle*/, Platform p) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist:
CHANGELOG.mdwas updated, if applicableDescription
I noticed that toasts are due to be refactored to be cross platform, so this change may or may not be value add at the moment. It's pretty basic, just adding the stream title to the notification and could also be used for the cross platform approach.
Partially closes #1297