Color mentions to match the mentioned users color

[kiwec]

Pull request checklist:

• CHANGELOG.md was updated, if applicable

Description

Fixes #1963
Fixes #2121

[TranRed]

should there be a setting for it or do we force this? I'd personally prefer not to use it

[leon-richardt]

should there be a setting for it or do we force this? I'd personally prefer not to use it

I agree that this is a very "opinionated" change, it adds too much visual "clutter" for my liking. I believe there should definitely be a setting for this.

[kiwec]

I should have explained that this change is not for visual fluff. I added it because it is necessary to be able to follow conversations in any reasonably large communities.

[ALazyMeme]

I should have explained that this change is not for visual fluff. I added it because it is necessary to be able to follow conversations in any reasonably large communities.

What yunglpr and tranred said is still applicable. Features that certain people want, others may not want. It should be an option, not a forced feature.

[leon-richardt]

I have some comments regardless of whether or not we eventually want a setting for this 😄

[kiwec]

Thanks for the feedback. I added a setting and fixed the issues pointed out by leon.

[zneix]

I like this feature and I think it's a nice addition overall :+1: Sorry for being a little pedantic over the code though :stuck_out_tongue:

Two more things:

1. You can include Fixes #1963 \n Fixes #2121 in PRs body to link the issues and close them upon merging.
2. What will happen when I send something like @asdasdasdasdasdasdasdxd? Chatterino will resolve this to a valid mention, but obviously such user doesn't exist - how would this feature behave in such cases?

[pajlada]

Looks good - the unresolved comments are still changes I'd like to see - after that I'll give it a whirl and we can get this merged in! Thanks a lot for contributing!

[kiwec]

Pushed the requested changes. 🙂

2. What will happen when I send something like @asdasdasdasdasdasdasdxd? Chatterino will resolve this to a valid mention, but obviously such user doesn't exist - how would this feature behave in such cases?

The default text color will be used (MessageColor::Text).

[pajlada]

Thanks for your contribution!

[zneix]

👍

[fanway]

Does it continuously populate color cache without ever clearing it?

[fanway]

Sorry btw to write after it have been merged xd