Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix quick switcher not ordering based on tab order #2561

Merged
merged 3 commits into from Mar 27, 2021
Merged

Fix quick switcher not ordering based on tab order #2561

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
67aaca2
Replace QSet with QList
jupjohn Mar 24, 2021
be9f116
Append bugfix to changelog
jupjohn Mar 24, 2021
e092d60
Add PR ID to changelog entry
jupjohn Mar 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Expand Up @@ -84,6 +84,7 @@
- Bugfix: Fix Twitch cheer emotes not displaying tooltips when hovered (#2434, #2503)
- Bugfix: Fix BTTV/FFZ channel emotes saying unknown error when no emotes found (#2542)
- Bugfix: Fix directory not opening when clicking "Open AppData Directory" setting button on macOS (#2531, #2537)
- Bugfix: Fix quickswitcher not respecting order of tabs when filtering (#2519, #2561)
- Dev: Updated minimum required Qt framework version to 5.12. (#2210)
- Dev: Migrated `Kraken::getUser` to Helix (#2260)
- Dev: Migrated `TwitchAccount::(un)followUser` from Kraken to Helix and moved it to `Helix::(un)followUser`. (#2306)
Expand Down
6 changes: 3 additions & 3 deletions src/widgets/dialogs/switcher/QuickSwitcherPopup.cpp
View file
Open in desktop
Expand Up @@ -14,14 +14,14 @@
namespace chatterino {

namespace {
QSet<SplitContainer *> openPages()
QList<SplitContainer *> openPages()
{
QSet<SplitContainer *> pages;
QList<SplitContainer *> pages;

auto &nb = getApp()->windows->getMainWindow().getNotebook();
for (int i = 0; i < nb.getPageCount(); ++i)
{
pages.insert(static_cast<SplitContainer *>(nb.getPageAt(i)));
pages.append(static_cast<SplitContainer *>(nb.getPageAt(i)));
}

return pages;
Expand Down