Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added in:<channels> search predicate #2634

Merged
merged 6 commits into from
Apr 17, 2021

Conversation

talneoran
Copy link
Contributor

Pull request checklist:

  • CHANGELOG.md was updated, if applicable

Description

See #2299 for more information.
This PR adds a search predicate (according to #1237) that allows filtering messages based on the channel they were sent in, meant for usage in /mentions.
This is also inspired by the similar filter in Discord.
Example usage:
in:fourtf would show messages originally sent in fourtf channel.
in:fourtf,pajlada would show messages originally sent in either fourtf or pajlada channels.

The things I'm not completely sure about now are:

  1. Currently the filter works everywhere, but is only useful in /mentions. If used in a regular split it will either show all messages or none, depending on whether or not the channel list includes the current channel. I'm wondering if there is a need to enforce this filter only being useable in /mentions, or if the current state is fine (at least to me the current functionality makes sense).
  2. The wording of the changelog entry / explanation of the feature.

Closes #2299

Copy link
Collaborator

@leon-richardt leon-richardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested for a few simple scenarios, and works as expected. 👍 I think this is a great use case for message search predicates (although I am probably a little biased 🙂)


I'm wondering if there is a need to enforce this filter only being useable in /mentions, or if the current state is fine (at least to me the current functionality makes sense).

I think the current state is fine. The behavior makes sense, and restricting it to /mentions now might only limit future use cases

CHANGELOG.md Show resolved Hide resolved
chatterino.pro Show resolved Hide resolved
src/widgets/helper/SearchPopup.cpp Outdated Show resolved Hide resolved
Copy link
Member

@pajlada pajlada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Will update branch and merge in after #2633

@pajlada pajlada enabled auto-merge (squash) April 17, 2021 10:55
@pajlada pajlada merged commit cceadf4 into Chatterino:master Apr 17, 2021
@talneoran talneoran deleted the search-messages-by-channel branch May 23, 2021 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search for channels in /mentions tab
3 participants