New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added in:<channels> search predicate #2634
Added in:<channels> search predicate #2634
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested for a few simple scenarios, and works as expected.
I'm wondering if there is a need to enforce this filter only being useable in /mentions, or if the current state is fine (at least to me the current functionality makes sense).
I think the current state is fine. The behavior makes sense, and restricting it to /mentions
now might only limit future use cases
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Pull request checklist:
CHANGELOG.md
was updated, if applicableDescription
See #2299 for more information.
This PR adds a search predicate (according to #1237) that allows filtering messages based on the channel they were sent in, meant for usage in /mentions.
This is also inspired by the similar filter in Discord.
Example usage:
in:fourtf
would show messages originally sent in fourtf channel.in:fourtf,pajlada
would show messages originally sent in either fourtf or pajlada channels.The things I'm not completely sure about now are:
Closes #2299