Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use double spaces instead of Chatterino character when possible #3081

Merged
merged 5 commits into from Aug 1, 2021
Merged

Use double spaces instead of Chatterino character when possible #3081

merged 5 commits into from Aug 1, 2021

Conversation

Mm2PL
Copy link
Collaborator

@Mm2PL Mm2PL commented Jul 28, 2021 •
edited

Pull request checklist:

  • CHANGELOG.md was updated, if applicable

Description

No issue. Can help eliminate issues with users noticing the Chatterino character. Double spaces are way less noticeable (Chatterino, Chatty and webchat don't even render those!) than a space and U+E0000.

@Mm2PL Mm2PL requested review from pajlada and zneix July 28, 2021 17:41
@zneix
Copy link
Collaborator

zneix commented Aug 1, 2021

when possible

Am I missing soemthing or are you straight-up removing our old solution instead?

@Mm2PL
Copy link
Collaborator Author

Mm2PL commented Aug 1, 2021

If there is no space, there is nothing to replace with a double space.

@pajlada pajlada enabled auto-merge (squash) August 1, 2021 12:19
@pajlada pajlada merged commit 77f6835 into Chatterino:master Aug 1, 2021
@pajlada pajlada deleted the feature/use_double_spaces_instead_of_chatterino_character_when_possible branch August 1, 2021 12:38
@nilyt
Copy link
Contributor

nilyt commented Aug 2, 2021

I didn't even know this was a feature, until I saw this change.
Always considered this behaviour a bug I wanted to fix eventually, as it happens seemingly randomly, breaks building SE pyramids, and was just a nuisance all around (to various people).

Where is this setting (getSettings()->allowDuplicateMessages) in the UI, so I can turn it off? Or is it not exposed in the UI (for reasons)?
I'd vote for it to be off by default for the mentioned reasons. At least I can't recall enabling something like that?
Or maybe I did? The name "allowDuplicateMessages" is something I'd associate with 'r9k' more than with what it does.

@Mm2PL
Copy link
Collaborator Author

Mm2PL commented Aug 2, 2021

Where is this setting (getSettings()->allowDuplicateMessages) in the UI, so I can turn it off?

here
2021-08-02_18-23

zneix added a commit to SevenTV/chatterino7 that referenced this pull request Aug 3, 2021
@zneix
Merge remote-tracking branch 'origin/master' into chatterino7
1ec8084 
Now we're on commit 95044ef; Changes from upstream we pulled:

- Minor: Now uses spaces instead of magic Unicode character for sending duplicate messages (Chatterino#3081)
- Minor: Added `channel.live` filter variable (Chatterino#3092, Chatterino#3110)
- Bugfix: Channel point redemptions from ignored users are now properly blocked. (Chatterino#3102)
@zneix zneix mentioned this pull request Aug 7, 2021
Closed
@zneix zneix mentioned this pull request Aug 14, 2021
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pajlada pajlada pajlada approved these changes

@zneix zneix zneix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Mm2PL @zneix @nilyt @pajlada