Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add guide for building chatterino2 on Windows with vcpkg #3634

Merged
merged 15 commits into from
May 15, 2022

Conversation

Ian321
Copy link
Contributor

@Ian321 Ian321 commented Mar 27, 2022

…e, msbuild and msvc

Pull request checklist:

  • CHANGELOG.md was updated, if applicable

Description

  • Wrote a guide on how to build the project using vcpkg on windows.
  • Fixed build errors as they came up

@pajlada
Copy link
Member

pajlada commented Apr 10, 2022

Looks good! Once you think this is finished I'd love to have the guide combined into the original Windows guide as a subcategory instead of its own document. Let me know if you think this doesn't make sense

@Ian321
Copy link
Contributor Author

Ian321 commented Apr 10, 2022

The current BUILDING_ON_WINDOWS.md is already 190 lines long and I thought of this as a clean new guide, as almost nothing from the current one applies to this.

@Ian321 Ian321 marked this pull request as ready for review April 17, 2022 16:32
vcpkg.json Show resolved Hide resolved
@pajlada pajlada changed the title Guide and some fixes to build chatterino2 on windows with vcpkg, cmak… Add guide for building chatterino2 on Windows with vcpkg May 15, 2022
@pajlada pajlada enabled auto-merge (squash) May 15, 2022 11:19
@pajlada pajlada merged commit addcbb1 into Chatterino:master May 15, 2022
@Felanbird Felanbird mentioned this pull request May 17, 2022
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants