Use login name for NotificationController lookup

[iProdigy]

Pull request checklist:

• CHANGELOG.md was updated, if applicable

Description

Fixes #3646

• Add userLogin, gameName to HelixStream
• Store userLogin instead of userName from streams response
• Lookup lowercase name in liveStreams set

[iProdigy]

Aside: this logic can be simplified now due to the gameName field, but someone else can do this refactor

[Mm2PL]

I'd say that a bugfix changelog entry is good for this. Also looks like this is my fault, added in #3442

[Felanbird]

I'd say that a bugfix changelog entry is good for this. Also looks like this is my fault, added in #3442

I took the assumption of Work towards meaning that another PR would be required to fix the underlying issue - and if necessary that changelog could include (#thisPR, #thatPR)

but as I test this PR I can see the calls are already fixed 🙂

[iProdigy]

Thanks for the confirmation felan, was planning to review the logic in NotificationController::checkStream if this alone didn't fix it

have added a changelog entry now

[Felanbird]

Issue is resolved - live notifications follow the specified case-sensitivity, but use intended display-name casing when the tab is open.