Delete 'is live' messages from non-open channels #3678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit c1339db.
…ssages_from_fake_channels
pajlada
approved these changes
Apr 30, 2022
Felanbird
reviewed
Apr 30, 2022
| @@ -10,6 +10,7 @@ | |||
| - Minor: Added chatter count for each category in viewer list. (#3683) | |||
| - Minor: Added option to open a user's chat in a new tab from the usercard profile picture context menu. (#3625) | |||
| - Bugfix: Fixed live notifications for usernames containing uppercase characters. (#3646) | |||
| - Bugfix: Fixed live notifications not getting updated for closed streams going offline. (#3678) | |||
There was a problem hiding this comment.
This Changelog will likely cause a wording conflict in the future, since this fixes fake channels and the Changelog sounds like it applies to normal channels who's tabs you've closed, but meh we'll see what happens.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist:
CHANGELOG.mdwas updated, if applicableDescription
A little copypasterino. Before a merge c1339db should be dropped to keep my stupid debugging code out of master :)