fix: parse irc tags with consecutive escapes #3711
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist:
CHANGELOG.md
was updated, if applicableDescription
When an irc tag has multiple escaped characters in a row, the current
parseTagString
function fails to see the 2nd\
due to the extrai++
(since the loop declaration already hasi++
and the string replacement eats two characters)Example:
system-msg=DefectiveCloak\s\sgifted\sa\sTier\s1\ssub\sto\saliiscrying!
(weird case where their display name has a trailing space)