Fixed viewer list not being closable with the escape key #3734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Felanbird
reviewed
May 14, 2022
also include search bar hotkey
xel86
force-pushed
the
fix/close-viewer-list-with-esc
branch
from
eb0f3a2
to
2a4e4d4
Compare
pajlada
approved these changes
May 14, 2022
pajlada
changed the title
pajlada
changed the title
Felanbird
reviewed
May 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changelog
Pull request checklist:
CHANGELOG.mdwas updated, if applicableDescription
Currently the viewer list isn't able to be closed using the escape key like the rest of the popups. This PR adds the PopupWindow hotkeys to the viewer list QDockWidget so that you can close it with the escape key and use the search hotkey to select the search field.
Closes #3569