-
-
Notifications
You must be signed in to change notification settings - Fork 442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added /requests command #3746
added /requests command #3746
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm sorry but I'm going to deny this one. With /openurl
and the extended placeholders that were added in #3155 you can create many creative commands like this one on your own, e.g.:
I just don't want extra code for something that doesn't need it at all.
P.S. I see that the thing this PR has and current implementation of placeholders don't is different behaviour when no arguments are provided.
Sure, at this point there's no default/fallback values but I believe it could be implemented in the near future, so that you could use /requests
in #forsen to open forsen's requests or use /requests pajlada
also in #forsen to open pajlada's requests.
On the other note, perhaps a little section with "examples" of how command placeholders can be used might be a cool addition - this PR alone being created in the first place shows that it is not as commonly known that these super useful placeholders exist. Just to show users that they can have something without much effort and show them how to do that. |
I added it because it's a command in webchat https://help.twitch.tv/s/article/chat-commands?language=en_US#AllMods i thought chatterino was meant to match as many default twitch commands as possible FeelsDankMan |
Oh, this is a completely different reasoning then. I had 0 Clue that such command exists in webchat. If it does then sure, we can add this. (Although it doesn't show up in Sorry for the unnecessary ruckus. |
17 maj 2022 11:41:16 Kasia ***@***.***>:
I had 0 Clue that such command exists in webchat.
I'm 99% sure it's a new command. I also thought this was a new custom thing.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change the brackets. Might be good to add this into the commands list on the wiki: https://github.com/Chatterino/wiki/blob/master/docs/Commands.md
Co-authored-by: Mm2PL <mm2pl+gh@kotmisia.pl>
I was thinking of this, but since it's a webchat command I didn't mention it, since we mainly went with commands that have some sort of separate functionality for that wiki page. |
Pull request checklist:
CHANGELOG.md
was updated, if applicableDescription
Opens the current channel's reward queue, can also take an input to open some other channel's queue.