Show all global FFZ badges of a user #3818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jaxkey
changed the title
|
I'm not sure if this is the correct approach, the FFZ Bot badges we load in Chatterino are a relic of the past and purely appear because they are in the same API as supporter badges. |
|
This doesn't really conflict with the transition to v2 since I don't think anyone is working on that right now, so I'm happy to merge this feature in. Will push a little commit cleaning up the code at the same time as I solve the merge conflict, then let @Jaxkey get the last review in |
Only expose a "getUserBadges" that returns a vector of badges, which can be empty for users with no badges
|
Looks good @pajlada. Merge it 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist:
CHANGELOG.mdwas updated, if applicableDescription
In Chatterino, a maximum of one global FFZ badge appears at a time.
Moobot has both the
Bot&FFZ Supporterglobal FFZ Badges.In Chatterino, the
Botbadge is missing and only one FFZ badge appears.Changed
badgeMapto store a vector of ID's in its second position for each FFZ badge a user has (previously only stored a single ID).Changed
appendFfzBadges()to loop through each FFZ badge a user has.Updated version:
To Reproduce
Have a user with multiple global FFZ badges send a chat message