-
-
Notifications
You must be signed in to change notification settings - Fork 442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added option to highlight your own messages #3833
Added option to highlight your own messages #3833
Conversation
Had someone test it and right now if you don't change the color then the highlight will be black instead of the default blue. Changing the color to anything else will work. I'll fix this either tomorrow or sunday |
I personally think this setting should not be enabled by default. |
I agree that it should be disabled by default, and I also think it should be under the "Users" tab |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small feedback, can give it a more proper check during the weekend
Use the ColorProvider self message highlight color instead of rolling our own non-updating color
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made some cosmetic changes, I'd like you to take a quick look at the code again and test things to ensure everything works as expected for you.
In addition, if you could update the PR with a new screenshot of what it looks like that would be nice
Tested on two separate accounts and works
Done Thanks for putting the finishing touches on this PR, completely forgot about it |
I think someone bumped me about it then deleted their comment :D |
Pull request checklist:
CHANGELOG.md
was updated, if applicableDescription
Adds a setting in the user highlights page to enable highlights for your own messages
Adds a highlight option in the users tab which highlights the current user's messages (automatic)
Closes #3814