Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added option to highlight your own messages #3833

Merged
merged 28 commits into from
Jan 30, 2023

Conversation

MrAuro
Copy link
Contributor

@MrAuro MrAuro commented Jun 24, 2022

Pull request checklist:

  • CHANGELOG.md was updated, if applicable

Description

Adds a setting in the user highlights page to enable highlights for your own messages

image

Adds a highlight option in the users tab which highlights the current user's messages (automatic)

Closes #3814

@MrAuro
Copy link
Contributor Author

MrAuro commented Jun 25, 2022

Had someone test it and right now if you don't change the color then the highlight will be black instead of the default blue. Changing the color to anything else will work.

I'll fix this either tomorrow or sunday

@pajlada pajlada marked this pull request as draft June 25, 2022 10:06
@leon-richardt
Copy link
Collaborator

I personally think this setting should not be enabled by default.

@pajlada
Copy link
Member

pajlada commented Jun 25, 2022

I agree that it should be disabled by default, and I also think it should be under the "Users" tab

@Felanbird Felanbird requested a review from pajlada June 27, 2022 01:54
@MrAuro MrAuro changed the title Fixed/added option for self message highlights Added highlight setting for automatically highlighting self messages Jun 27, 2022
Copy link
Member

@pajlada pajlada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small feedback, can give it a more proper check during the weekend

CHANGELOG.md Outdated Show resolved Hide resolved
src/controllers/highlights/HighlightController.cpp Outdated Show resolved Hide resolved
src/providers/colors/ColorProvider.hpp Outdated Show resolved Hide resolved
src/singletons/Settings.hpp Outdated Show resolved Hide resolved
@pajlada pajlada marked this pull request as ready for review January 29, 2023 12:09
Copy link
Member

@pajlada pajlada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made some cosmetic changes, I'd like you to take a quick look at the code again and test things to ensure everything works as expected for you.

In addition, if you could update the PR with a new screenshot of what it looks like that would be nice

Feedback from others: How is this default color choice?
image

@MrAuro
Copy link
Contributor Author

MrAuro commented Jan 29, 2023

I made some cosmetic changes, I'd like you to take a quick look at the code again and test things to ensure everything works as expected for you.

Tested on two separate accounts and works

In addition, if you could update the PR with a new screenshot of what it looks like that would be nice

Done

Thanks for putting the finishing touches on this PR, completely forgot about it

@MrAuro MrAuro requested a review from pajlada January 29, 2023 17:13
@pajlada
Copy link
Member

pajlada commented Jan 29, 2023

Thanks for putting the finishing touches on this PR, completely forgot about it

I think someone bumped me about it then deleted their comment :D

@pajlada pajlada changed the title Added highlight setting for automatically highlighting self messages Added option to highlight your own messages Jan 30, 2023
@pajlada pajlada merged commit d6ccab2 into Chatterino:master Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

self user highlights no longer working
3 participants