fix(Split): always refresh tab when channel is set #3849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Previously, the title of the containing tab was only updated when a split's channel was set through the SelectChannelDialog. This lead to the bug described in Chatterino#3845. With this commit, the refresh action is moved into the Split::setChannel method, unifying the behavior.
leon-richardt
force-pushed
the
fix/split/always-refresh-tab-on-channel-set
branch
from
f8f16ca
to
1a73921
Compare
leon-richardt
changed the title
pajlada
approved these changes
Jul 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist:
CHANGELOG.mdwas updated, if applicableDescription
Previously, the title of the containing tab was only updated when a split's channel was set through the SelectChannelDialog. This lead to the bug described in #3845.
With this commit, the refresh action is moved into the Split::setChannel method, unifying the behavior.
Note: The changes in this PR were previously a part of #3848.
Fixes #3845