fix: prevent system messages from being ignored in multi-channel search #3875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist:
CHANGELOG.mdwas updated, if applicableDescription
This PR aims to fix #3870 where search predicates that act on system messages (ie. bans, timeouts) would not show system messages. This was caused by an oversight in the multi-channel search filtering logic that attempted to filter out duplicate messages (meant to catch the same channel in multiple splits) but ended up treating the ID-less system messages as duplicates.
NOTE: it looks like the channel name isn't prepended to system messages, I'll create a separate fix for this
Behaviour prior to fix (banned in 2 channels):
Post-fix:
