Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added minimal supported macOS version to CI builds. #3923

Merged
merged 1 commit into from
Aug 15, 2022

Conversation

23rd
Copy link
Contributor

@23rd 23rd commented Aug 14, 2022

Pull request checklist:

  • CHANGELOG.md was updated, if applicable

Description

Recently, nightly builds stopped working on macOS with outdated versions (I guess this is caused by the macos-latest being macos-11.0).

Popup image

That makes me sad.
Let's support macOS Catalina for a while.

@pajlada
Copy link
Member

pajlada commented Aug 14, 2022

Does this make the builds stop working on newer macos systems? If not then this is fine by me for now.
Long term, I suppose expanding the number of macos builds would be the way to go but I'd rather not do that until we've refactored the build workflows

@jupjohn
Copy link
Contributor

jupjohn commented Aug 14, 2022

It should be noticed that macOS Catalina (10.5) is marked a deprecated on GitHub's runner page. I'd rather we didn't support deprecated images but I understand that a fair chunk of users still use 10.5.

Source: https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners#supported-runners-and-hardware-resources

@23rd
Copy link
Contributor Author

23rd commented Aug 14, 2022

Does this make the builds stop working on newer macos systems?

A result binary (from CI) works on 12.5 as well.

It should be noticed that macOS Catalina (10.5) is marked a deprecated on GitHub's runner page.

My PR does not change a version of the macOS runner, it is still macos-latest.

@jupjohn
Copy link
Contributor

jupjohn commented Aug 14, 2022

My PR does not change a version of the macOS runner, it is still macos-latest.

Misread, sorry!

Copy link
Member

@pajlada pajlada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging this in as in as a stop-gap solution

Would be nice with a support matrix for what versions of OSes we support, not sure if it makes sense to keep in the wiki or the repo.

like

os support
macos montgomery (12.5) ✔️
macos scooby (11.7) ✔️*requires manual installation of libXD

@pajlada pajlada merged commit 34ee278 into Chatterino:master Aug 15, 2022
@Felanbird Felanbird mentioned this pull request Jan 16, 2023
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants