Allow hiding moderation actions in streamer mode #3926
Conversation
|
clang-tidy review says "All clean, LGTM! 👍" |
There was a problem hiding this comment.
I'm surprised someone actually bothered requesting my - review on anything... few last merges definitely show like you don't need me here
people just approve changes like this here without even paying attention to details, while also disregarding me or my opinion, then complain about quirks that exist in master because "somehow that mistake got merged in.." 🙄
@zneix This comment has nothing to do with the review of this code. Mistakes happen, we fix them and move on - we're human. It's also inconsiderate to the other maintainers/developers of chatterino to claim they don't pay attention to the details when reviewing additions to the project. I'm sure they do in fact care about the quality of what's going in to the codebase as does the community because they care about the software they use. You chose to step away from the project for a bit which is understandable and respectable - but to come back and claim that your opinion isn't respected by the community or that they're actively disregarding your input is ignorant of the fact that you made that choice to back off. I personally find your skills and knowledge of chatterino's domain valuable. The drama however, is annoying and doesn't contribute anything positive to the developer community. I would encourage you to think about how you're impacting the community by exhibiting this sort of behaviour and grow from it. |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
clang-tidy review says "All clean, LGTM! 👍" |
Pull request checklist:
CHANGELOG.mdwas updated, if applicableDescription
This adds a new setting to streamer mode which will hide any moderation messages. This doesn't hide moderated messages, that could be another PR. This hides any messages which have the Timeout or Untimeout flags, exactly like the Show moderation messages setting. Also of note: this won't hide timeout responses for commands you run.
Closes #2729.