Migrate /emoteonly and /emoteonlyoff commands to the Helix API #4015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nerixyz
commented
Sep 28, 2022
Comment on lines
+1808
to
+1820
| auto currentUser = getApp()->accounts->twitch.getCurrent(); | ||
| if (currentUser->isAnon()) | ||
| { | ||
| channel->addMessage(makeSystemMessage( | ||
| "You must be logged in to update chat settings!")); | ||
| return ""; | ||
| } | ||
| auto *twitchChannel = dynamic_cast<TwitchChannel *>(channel.get()); | ||
| if (twitchChannel == nullptr) | ||
| { | ||
| channel->addMessage(makeSystemMessage( | ||
| "The /emoteonlyoff command only works in Twitch channels")); | ||
| return ""; |
There was a problem hiding this comment.
This is almost the same as in other twitch commands. In my opinion you should be able to do something like this:
this->registerTwitchCommand("/xd",
[](const QStringList&,
std::shared_ptr<TwitchChannel>,
std::shared_ptr<TwitchAccount>) {
// ...
});![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
pajlada
reviewed
Oct 1, 2022
pajlada
approved these changes
Oct 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist:
CHANGELOG.mdwas updated, if applicableDescription
This is the first part of updating commands that use the Update Chat Settings endpoint.
Fixes #3966, #3967.