Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Show Emoji Completion in IRC Channels #4021

Merged
merged 2 commits into from
Sep 30, 2022

Conversation

Nerixyz
Copy link
Contributor

@Nerixyz Nerixyz commented Sep 30, 2022

Pull request checklist:

  • CHANGELOG.md was updated, if applicable

Description

The emote completion popup wasn't shown in irc channels and it had no emojis added. Note that emojis in sent message use the system's emojis (see #4020).

Fixes #3550.

@Nerixyz Nerixyz marked this pull request as ready for review September 30, 2022 19:44
@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

Copy link
Collaborator

@Felanbird Felanbird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it works 👍
c2_4021

@pajlada pajlada merged commit 9554b83 into Chatterino:master Sep 30, 2022
@Nerixyz Nerixyz deleted the fix/irc-emoji-popup branch September 30, 2022 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[IRC] Despite emote window having emojis in IRC channels, : doesn't prompt anything to autocomplete
3 participants