Enable Helix timegating #4035
Enable Helix timegating #4035
Conversation
Currently only active for the /raid command
|
:( |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
How it's intended to be used can be seen here: https://github.com/Chatterino/chatterino2/blob/54129f7/src/controllers/commands/CommandController.cpp#L1988-L2009 |
There was a problem hiding this comment.
Changes look good.
I would like the squashed commit message to mention that this commit only enables timegating for /raid.
I also think we should link to the deprecation announcement somewhere in the changelog, since it's referenced so often. Maybe this PR is not the right place for it though.
What do you think?
My idea was to have a wiki page or something that we can link to in the changelog and potentially in commands that explains what the deprecation means for Chatterino, and that will link to the deprecation announcement |
|
clang-tidy review says "All clean, LGTM! 👍" |
Pull request checklist:
CHANGELOG.mdwas updated, if applicableDescription
For commands affected by the timegating, they will continue to use their IRC command equivalent until the 11th of February, 2023.
This is one week before the actual migration is supposed to start. The wording of the date is shaky, so we start a bit before to be sure.
Any highly affected commands will have a temporary setting at the bottom of the General settings page to override the timegating functionality.
Any commands that are affected will also have their changelog entry updated to notify of the timegating.