Make menus and placeholders display appropriate custom key combos. #4045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Mm2PL
changed the title
this does not update dynamically!
|
If your messing with hotkeys, your may fix #3474 as well |
That should be a different PR as it has nothing to do with the scope of this one. |
Getting side-tracked and introducing out-of-scope changes is the best way to never finish a PR. It's better to finish one and then start another. Custom hotkeys was already an awfully large PR (scope-wise, not code) and I honestly don't want to do anything that big. |
pajlada
requested changes
Oct 9, 2022
pajlada
approved these changes
Oct 9, 2022
|
@Mm2PL Feel free to merge in when you're happy! |
|
Skipping FreeBSD build on Cirrus for now |
pajlada
deleted the
feature/custom_hotkeys_pr_two_the_electric_boogaloo
branch
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist:
CHANGELOG.mdwas updated, if applicableDescription
Closes #4039.
Todo:
neededArgumentsworkSplitHeader
[-] Settings
Notebook (hide tabs)
SplitInputthat's a Qt menu.something more?
All the commits mentioning scuffed-ness need some kind of relayout or app restart to update the key bind description.