Migrate /w to Helix API
#4052
Merged
Migrate /w to Helix API
#4052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nerixyz
commented
Oct 7, 2022
| @@ -181,28 +181,6 @@ bool appendWhisperMessageWordsLocally(const QStringList &words) | |||
| return true; | |||
| } | |||
|
|
|||
| bool appendWhisperMessageStringLocally(const QString &textNoEmoji) | |||
There was a problem hiding this comment.
I'm not too confident in removing this, but I couldn't really see a reason for this to exist other than maybe some dryRun stuff.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Felanbird
previously requested changes
Oct 8, 2022
pajlada
approved these changes
Oct 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist:
CHANGELOG.mdwas updated, if applicableDescription
This migrates both
/wand.wto the Helix API since.wwasn't sent directly to IRC.Closes #3986.
Also some parts of #1163 will be fixed.