Migrate /commercial command to the Helix API #4094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
pajlada
requested changes
Nov 3, 2022
There was a problem hiding this comment.
just some nitpicks, other than that looks good and works as expected
if you would, please create a github issue for:
- retry_after missing from cooldowned requests
- error for invalid length contains the wrong message
invalid length response:
{
"data": [],
"error": "Bad Request",
"message": "To start a commercial, the broadcaster must be streaming live.",
"status": 400
}
|
Additionally, I opened a github issue for twitch to fix the issues mentioned: twitchdev/issues#686 |
pajlada
approved these changes
Nov 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist:
CHANGELOG.mdwas updated, if applicableDescription
Migrated the commercial command to the new helix API. Functionality is timegated so the command uses the IRC functionality as long as possible. I yoinked this PR from pajlada with his permission, approximately 57.8% of this PR's code is his 馃 !
Closes #3964