Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial backend test for user-based data/customizations #4144

Merged
merged 5 commits into from
Nov 13, 2022

Conversation

pajlada
Copy link
Member

@pajlada pajlada commented Nov 12, 2022

Pull request checklist:

  • CHANGELOG.md was updated, if applicable

Description

  • Add proposed system for user-specific customizations
  • fix tests

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

@pajlada pajlada force-pushed the feat/user-customizations branch 4 times, most recently from dd0c620 to cf22e1c Compare November 13, 2022 14:18
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

src/controllers/userdata/UserData.hpp Show resolved Hide resolved
This can be used to customize a users colors or username, or other
user-specific things

Things will be stored per provider (i.e. Twitch) ID
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

src/controllers/userdata/UserData.hpp Show resolved Hide resolved
Leave color empty to unset it
@pajlada pajlada changed the title Proposal for user-id based user customizations Initial backend test for user-based data/customizations Nov 13, 2022
@pajlada pajlada enabled auto-merge (squash) November 13, 2022 15:51
@pajlada pajlada merged commit 1eabda8 into master Nov 13, 2022
@pajlada pajlada deleted the feat/user-customizations branch November 13, 2022 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant