Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix users being assigned duplicate FrankerFaceZ badges #4156

Merged
merged 3 commits into from
Nov 16, 2022

Conversation

pajlada
Copy link
Member

@pajlada pajlada commented Nov 16, 2022

Pull request checklist:

  • CHANGELOG.md was updated, if applicable

Description

  • Ensure users cannot have the same FrankerFaceZ badge more than once
  • Add changelog entry

@pajlada pajlada enabled auto-merge (squash) November 16, 2022 09:33
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

#include "common/Aliases.hpp"
#include "common/UniqueAccess.hpp"
#include "util/QStringHash.hpp"

#include <QColor>
#include <boost/optional.hpp>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: 'boost/optional.hpp' file not found [clang-diagnostic-error]

#include <boost/optional.hpp>
         ^

@pajlada pajlada merged commit 991cf63 into master Nov 16, 2022
@pajlada pajlada deleted the fix/ffz-duplicate-badges branch November 16, 2022 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant