Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add echo-message support for IRC #4157

Merged
merged 6 commits into from
Nov 18, 2022
Merged

Add echo-message support for IRC #4157

merged 6 commits into from
Nov 18, 2022

Conversation

Mm2PL
Copy link
Collaborator

@Mm2PL Mm2PL commented Nov 16, 2022

Pull request checklist:

  • CHANGELOG.md was updated, if applicable

Description

This now means that if available messages will be server-side rendered on IRC 🎉

To test: just connect to ZNC or basically any modern IRC server. There won't be a difference between sending a message with /raw and normally because everything is 99.99% sent through the server anyway. 🎉

@Mm2PL Mm2PL requested a review from pajlada November 16, 2022 23:31
@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

Copy link
Member

@pajlada pajlada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@Mm2PL merge this in when you and CI are happy (I did some sneak changes)

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@Mm2PL Mm2PL merged commit 8627d6c into master Nov 18, 2022
@Mm2PL Mm2PL deleted the feature/echo-message branch November 18, 2022 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants