-
-
Notifications
You must be signed in to change notification settings - Fork 442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🔨 Automatically generate resources files with cmake #4159
Conversation
Looks great, this approach looks good to me. Thank you for taking the effort and looking into this! Poke me whenever you feel this is ready for a proper review or if you need a Linux tester. |
clang-tidy review says "All clean, LGTM! 👍" |
Works on macOS 👍 My editor also finds the |
clang-tidy review says "All clean, LGTM! 👍" |
QtCreator on windows is 🆗 now |
tested 6497570 with vcpkg on windows and works fine |
@pajlada This PR should be ready for a review now |
Code looks good, testing Linux vim experience now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Linux vim experience works great 👍
Is there any further testing you would want before haaving this merged in @AnotherFoxGuy ? |
I think that it has been tested on all platforms now, so I think it is ready to merge |
clang-tidy review says "All clean, LGTM! 👍" |
This PR replaces
resources/generate_resources.py
with a cmake script that will automatically generate the required resource filesTodo:
CHANGELOG.md
Fixes #3949