fix: Limiting the height of a message that contains some RTL text causes a crash #4168
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist:
CHANGELOG.md
was updated, if applicableDescription
This is an attempt at fixing the crash.
Currently, the ellipsis is misplaced (since it's not really added):
It should be added at the first position (like it's done in browsers if the
direction
isrtl
).Fixes #4166. Thanks to @mohad12211 for making the ellipsis adding simple.
Test Messages
Ellipsis on the left
Ellipsis on the right