Fix issue with VIPs who have Asian Language display names #4174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Felanbird
commented
Nov 21, 2022
|
clang-tidy review says "All clean, LGTM! 👍" |
iProdigy
approved these changes
Nov 21, 2022
|
clang-tidy review says "All clean, LGTM! 👍" |
this will later be merged with ## Unreleased into a big 2.4.0
pajlada
approved these changes
Nov 21, 2022
Felanbird
changed the title
/vips response
|
clang-tidy review says "All clean, LGTM! 👍" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist:
CHANGELOG.mdwas updated, if applicableDescription
In a previous life, the IRC
/vipsresponse returned theloginNameof said VIPs. One day we woke up and Twitch suddenly started sending us thedisplayName's of those VIPs.The problem with this was the fact that display names containing Asian language characters are of no use to us in Chatterino, as Twitch has no way of looking up a user, by these names.
Due to the migration of the
/vipscommand to the Helix API, this fix will only help broadcasters (after the Timegate), but I do think it's better for them to be able to use the usercard feature in Chatterino, from the VIPs response.Also suggested as a fix in #4053 (comment)
Fixes #3524