Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix white border appearing around maximized window #4190

Merged
merged 4 commits into from
Nov 25, 2022

Conversation

kornes
Copy link
Contributor

@kornes kornes commented Nov 25, 2022

Pull request checklist:

  • CHANGELOG.md was updated, if applicable

Description

changes:

  • use -1 margins passed to DwmExtendFrameIntoClientArea to effectively disable invisible window borders, which caused white border to appear around maximized windows (visible on 2nd monitor)
  • tiny refactor of WM_NCCALCSIZE handling

fixes #2205

tested on:

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment
@github-actions

This comment was marked as duplicate.

@pajlada
Copy link
Member

pajlada commented Nov 25, 2022

any win11 testers? @ALazyMeme ?

@flex3r
Copy link
Contributor

flex3r commented Nov 25, 2022

White borders were actually never an issue on Windows 11 for me, only on my Windows 10 machine.
However, I still experienced some ui elements bleeding over to my 2nd monitor, like link previews or thumbnails.
I tested this PR with the windows-latest, 5.15.2 build and could not reproduce this kind of behavior anymore. 🎉
Currently running Windows 11 Pro 22H2

@pajlada
Copy link
Member

pajlada commented Nov 25, 2022

Occluder confirmed it fixes his issue too

@pajlada pajlada enabled auto-merge (squash) November 25, 2022 20:12
@pajlada pajlada merged commit f2b35fb into Chatterino:master Nov 25, 2022
@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@kornes kornes deleted the fix_windows-white-border branch November 26, 2022 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maximizing Chatterino creates a border on adjacent monitors
3 participants