Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Setting to Hide Reply Context #4224

Merged
merged 6 commits into from
Dec 7, 2022

Conversation

Nerixyz
Copy link
Contributor

@Nerixyz Nerixyz commented Dec 7, 2022

Pull request checklist:

  • CHANGELOG.md was updated, if applicable

Description

As discussed in #4220:

Some people don't like reply threads or how they're displayed in Chatterino and want to "hide replies" - hide the reply context.

My thinking was to add a setting that hides the reply context in the rendered messages, so these messages look like regular messages. I don't think adding a setting that completely ignores replies is good, as it will overcomplicate a lot of the code.

src/providers/twitch/IrcMessageHandler.cpp Outdated Show resolved Hide resolved
src/widgets/helper/ChannelView.cpp Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

github-actions bot commented Dec 7, 2022

clang-tidy review says "All clean, LGTM! 👍"

@pajlada pajlada enabled auto-merge (squash) December 7, 2022 20:38
@pajlada pajlada merged commit ff54b4c into Chatterino:master Dec 7, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Dec 7, 2022

clang-tidy review says "All clean, LGTM! 👍"

@Nerixyz Nerixyz deleted the fix/setting-reply-threads branch December 8, 2022 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants