-
-
Notifications
You must be signed in to change notification settings - Fork 442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove sending part of the multipart emoji workaround #4361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Did multi-part emojis get "native" support from Twitch now? |
They fixed it in March of last year but removing this wasn't really on the top of the todo list |
Felanbird
approved these changes
Feb 9, 2023
zneix
approved these changes
Feb 9, 2023
pajlada
requested changes
Feb 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing removal from CommandController.cpp sendWhisperMessage
zneix
approved these changes
Feb 9, 2023
pajlada
approved these changes
Feb 9, 2023
Mm2PL
changed the title
Remove sending part of the emoji rfc impl
Remove sending part of the multipart emoji workaround
Feb 9, 2023
Felanbird
added a commit
that referenced
this pull request
Feb 16, 2023
Felanbird
added a commit
that referenced
this pull request
Feb 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist:
CHANGELOG.md
was updated, if applicableDescription
Now chatterino will use ZERO WIDTH JOINER when sending messages again.