Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove sending part of the multipart emoji workaround #4361

Merged
merged 5 commits into from
Feb 9, 2023

Conversation

Mm2PL
Copy link
Collaborator

@Mm2PL Mm2PL commented Feb 9, 2023

Pull request checklist:

  • CHANGELOG.md was updated, if applicable

Description

Now chatterino will use ZERO WIDTH JOINER when sending messages again.

@leon-richardt
Copy link
Collaborator

Did multi-part emojis get "native" support from Twitch now?

@Mm2PL
Copy link
Collaborator Author

Mm2PL commented Feb 9, 2023

Twitch doesn't break them now.
image

@Felanbird
Copy link
Collaborator

Did multi-part emojis get "native" support from Twitch now?

They fixed it in March of last year but removing this wasn't really on the top of the todo list

Copy link
Member

@pajlada pajlada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing removal from CommandController.cpp sendWhisperMessage

CHANGELOG.md Outdated Show resolved Hide resolved
@Mm2PL Mm2PL requested a review from pajlada February 9, 2023 14:57
@Mm2PL
Copy link
Collaborator Author

Mm2PL commented Feb 9, 2023

ii2pl

@Mm2PL Mm2PL changed the title Remove sending part of the emoji rfc impl Remove sending part of the multipart emoji workaround Feb 9, 2023
@Mm2PL Mm2PL merged commit d38187f into master Feb 9, 2023
@Mm2PL Mm2PL deleted the chore/make_emoji_rfc_into_decode_only branch February 9, 2023 15:45
Felanbird added a commit that referenced this pull request Feb 16, 2023
Felanbird added a commit that referenced this pull request Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants