Dim disabled items in context menus #4423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nerixyz
changed the title
Felanbird
approved these changes
Mar 4, 2023
|
I imagine this should just be settable by the theme itself? now that themes are JSON-bound remove draft & poke me when it's ready for review again and I can take a look |
Wissididom
reviewed
Apr 28, 2023
CHANGELOG.md
Outdated
| @@ -27,6 +27,7 @@ | |||
| - Bugfix: Fixed Twitch channel-specific filters not being applied correctly. (#4529) | |||
| - Bugfix: Fixed emote & badge tooltips not showing up when thumbnails were hidden. (#4509) | |||
| - Bugfix: Fixed links with invalid IPv4 addresses being parsed. (#4576) | |||
| - Bugfix: Fixed disabled items in context-menus having a weird or the default text color. (#4423) | |||
There was a problem hiding this comment.
Suggested change
| - Bugfix: Fixed disabled items in context-menus having a weird or the default text color. (#4423) | |
| - Bugfix: Fixed disabled items in context-menus having a weird text-effect or the default text color. (#4423) |
Not sure if that suggestion would be correct, but I wanted to point out that it seems to me that there is a word missing
There was a problem hiding this comment.
When I think about it, it might even have been correct, if so, I'm sorry
pajlada
requested changes
Apr 29, 2023
pajlada
changed the title
pajlada
added a commit
that referenced
this pull request
May 2, 2023
4 tasks
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist:
CHANGELOG.mdwas updated, if applicableDescription
The items in the context-menu, that shows up when right-clicking the input, all had the same text color. When right-clicking in any other input, the text had an "etched" text effect (#1991). This PR dims these disabled items and removes the text-effect. I have no clue why setting a
borderdisables this text effect. There are some references to anetch-diabled-text, but that doesn't seem to (have) work(ed).Fixes #1991.