Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update lib/settings and lib/signals #4503

Merged
merged 2 commits into from
Apr 2, 2023
Merged

Update lib/settings and lib/signals #4503

merged 2 commits into from
Apr 2, 2023

Conversation

Nerixyz
Copy link
Contributor

@Nerixyz Nerixyz commented Apr 2, 2023

Pull request checklist:

  • CHANGELOG.md was updated, if applicable

Description

Since dependabot updates for settings and signals are explicitly disabled, I'm updating them here manually. The main purpose is to remove some warnings when using the libraries. One prominent warning comes from settingslistener.hpp (fixed in pajlada/settings#37):

lib\settings\include\pajlada/settings/settinglistener.hpp(31): warning C4458: declaration of 'cb' hides class member
lib\settings\include\pajlada/settings/settinglistener.hpp(12): note: see declaration of 'pajlada::SettingListener::cb'

@pajlada pajlada merged commit 5836073 into Chatterino:master Apr 2, 2023
15 checks passed
@Nerixyz Nerixyz deleted the deps/settings-and-signals branch April 2, 2023 12:47
@ilya-zlobintsev ilya-zlobintsev mentioned this pull request Jan 30, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pajlada pajlada pajlada approved these changes

Assignees
No one assigned
Labels
no changelog entry needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Nerixyz @pajlada