Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restart the sound device if it's been stopped #4549

Merged
merged 1 commit into from
Apr 16, 2023

Conversation

pajlada
Copy link
Member

@pajlada pajlada commented Apr 16, 2023

Description

Fixes a bug where we don't check if the sound device is active before trying to play a sound to it

We fix this by checking its state before every sound we try to play, and if the device is not in the started state we try to restart it.

@pajlada pajlada linked an issue Apr 16, 2023 that may be closed by this pull request
4 tasks
@pajlada pajlada mentioned this pull request Apr 16, 2023
4 tasks
@pajlada
Copy link
Member Author

pajlada commented Apr 16, 2023

image

@pajlada pajlada merged commit 8124ab4 into master Apr 16, 2023
15 checks passed
@pajlada pajlada deleted the fix/miniaudio-bug-lost-device-windows branch April 16, 2023 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Highlight audio breaks on Windows
1 participant