Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark experimental builds at the start of their filename #4551

Conversation

pajlada
Copy link
Member

@pajlada pajlada commented Apr 16, 2023

Description

also manually mark the builds as experimental instead of using a god of
war sed replace

The test for if this works can only be checked in the nightly release once this has been merged into the main branch

also manually mark the builds as experimental instead of using a god of
war sed replace
Copy link
Collaborator

@Mm2PL Mm2PL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pepega 📣 EXPERIMENTAL

@Felanbird Felanbird changed the title Make experimental builds be marked at the start of their filename Mark experimental builds at the start of their filename Apr 16, 2023
@Felanbird Felanbird merged commit 169f419 into master Apr 16, 2023
15 checks passed
@Felanbird Felanbird deleted the chore/mark-experimental-builds-as-experimental-at-the-beginning-of-the-filename branch April 16, 2023 22:03
@Mm2PL
Copy link
Collaborator

Mm2PL commented Apr 16, 2023

@Felanbird
Copy link
Collaborator

Felanbird commented Apr 17, 2023

edit: Now that I look at it again Chatterino-ubuntu-22.04-Qt-6.2.4.deb isn't one of the options prior to this PR - looks like it never made it but it's only an issue now because we are explicitly looking for it. https://github.com/Chatterino/chatterino2/releases/tag/nightly-build

For some reason the Chatterino-ubuntu-22.04-Qt-6.2.4.deb file is just not downloading.
Throwing ls into the mix returns all the artifacts except that one
https://github.com/Felanbird/chatterino2/actions/runs/4716725597/jobs/8365024218

(was also trying setting the path manually, encase working-directory wasn't working)

@Wissididom
Copy link
Contributor

Wissididom commented Apr 17, 2023

I assume it could also be that it simply overwrites the file. When I look into Felanbirds Workflow I see that those Ubuntu files do not contain anything that specifies the Qt version and since 22.04 is built for 5.15.2 and 6.2.4 the 5.15.2 version might just have been overwritten by the 6.2.4 version when downloading (when looking at the step order), because both are named Chatterino-ubuntu-22.04-x86_64.deb. So I see 3 options being either to rename the file inside the CreateUbuntuDeb.sh or somewhere prior to uploading it or to download it and after downloading the 5.15.2 to rename it and then downloading the 6.2.4 and rename that.

Their filenames currently are Chatterino-ubuntu-20.04-x86_64.deb and Chatterino-ubuntu-22.04-x86_64.deb according to Felanbirds Workflow.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants