馃洝 Add /shield and /shieldoff 馃洝
#4580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pajlada
approved these changes
May 7, 2023
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| #include "providers/twitch/TwitchAccount.hpp" | ||
| #include "providers/twitch/TwitchChannel.hpp" | ||
|
|
||
| namespace chatterino::commands { |
There was a problem hiding this comment.
warning: modification of 'std' namespace can result in undefined behavior [cert-dcl58-cpp]
namespace chatterino::commands {
^Additional context
/usr/include/c++/11/bits/unique_ptr.h:44: 'std' namespace opened here
namespace std _GLIBCXX_VISIBILITY(default)
^|
|
||
| QString toggleShieldMode(const CommandContext &ctx, bool isActivating) | ||
| { | ||
| const QString command = |
There was a problem hiding this comment.
warning: variable 'command' is not initialized [cppcoreguidelines-init-variables]
Suggested change
| const QString command = | |
| const QString command = 0 = |
| }, | ||
| [channel = ctx.channel](const auto error, const auto &message) { | ||
| using Error = HelixUpdateShieldModeError; | ||
| QString errorMessage = "Failed to update shield mode - "; |
There was a problem hiding this comment.
warning: variable 'errorMessage' is not initialized [cppcoreguidelines-init-variables]
Suggested change
| QString errorMessage = "Failed to update shield mode - "; | |
| QString errorMessage = 0 = "Failed to update shield mode - "; |
| @@ -0,0 +1,16 @@ | |||
| #pragma once | |||
|
|
|||
| #include <QString> | |||
There was a problem hiding this comment.
warning: 'QString' file not found [clang-diagnostic-error]
#include <QString>
^
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the
/shieldand/shieldoffcommands that toggle shield mode. Shield mode is not tracked internally. If shield mode is active and/shieldis used, there will be just be a message, saying "Shield mode was activated." (which is true - shield mode was activated in the past - even more: it hasn't been disabled since). There's little-to-no point in checking the shield mode before, because it might be changed between checking and updating. The only reason this should be done is to provide the user with the name of the moderator that enabled shield mode (this isn't sent if the mode didn't change for some reason).Closes #4206.