Prevent Generation of Crashdumps When the Browser Is Closed #4667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nerixyz
force-pushed
the
fix/browser-extension-crash
branch
from
53ab4ed
to
c5f5080
Compare
pajlada
approved these changes
Jun 4, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a
_Exit(0)when the STDIN of the browser-extension process reaches EOF, which would previously generate a crashdump.Fixes #4601.
While testing, I noticed an assertion (
assertInGuiThread) inNativeMessagingServer::ReceiverThread::handleMessage, when running in debug mode withC_DEBUG_NM. This was becausegetAppwas called in the receiver thread. Sinceappis only used in thepostToThread, I moved it there.