Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect Theme in Input Completion & Quick Switcher #4671

Merged
merged 9 commits into from
Jun 10, 2023

Conversation

Nerixyz
Copy link
Contributor

@Nerixyz Nerixyz commented Jun 7, 2023

Description

Previously, the theme wasn't respected in GenericListViews - this is now the case. It's mostly for the input completion popup.

Input Completion

Theme Black Dark Light White
Before before-black before-dark before-light before-white
After after-black after-dark after-light after-white

Quick Switcher

Theme Black Dark Light White
Before before-black before-dark before-light before-white
After after-black after-dark after-light after-white

Copy link
Member

@pajlada pajlada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the visual changes lgtm 👍

CHANGELOG.md Outdated Show resolved Hide resolved
src/widgets/listview/GenericListView.cpp Outdated Show resolved Hide resolved
@pajlada pajlada changed the title Respect Theme in GenericListViews Respect Theme in Input Completion & Quick Switcher Jun 10, 2023
@pajlada pajlada enabled auto-merge (squash) June 10, 2023 11:49
@pajlada pajlada merged commit 839ba60 into Chatterino:master Jun 10, 2023
14 checks passed
@Nerixyz Nerixyz deleted the fix/theme-list-view branch June 10, 2023 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants