Don't add QLayouts to QWidgets that already have one #4672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
pajlada
approved these changes
Jun 10, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Looking at the logs of Chatterino, you sometimes find a
QLayout: Attempting to add QLayout "" to QWidget "", which already has a layout. This StackOverflow answer has a good explanation.If you have a
QLayout foo(widget)and aQLayout bar(widget), then the first constructor will set the layout ofwidgetto befoo- callingsetLayout. The second constructor will try to set the layout as well, which will fail, becausewidget's layout was already set, and you can't overwrite the layout if it already exists. The thing to keep in mind: The constructor of aQLayoutautomatically sets the layout for the widget that's passed in as the parent.This PR removes these instances (I hope I didn't miss any).