Fix spacing issue with mentions inside RTL text #4677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mohad12211
force-pushed
the
fix-rtl-username
branch
from
3c45354
to
c5029d2
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Also store a reference to the element
pajlada
approved these changes
Jun 10, 2023
pajlada
changed the title
4 tasks
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Treat elements with usernames (mentions) as neutral elements
Before PR:
After PR:
Spacing issue is solved.
Also fixes the comma "," so that it's to the left of the mention (should be the case since text should be read from RTL)
The change is only in the function
reoderRTLso LTR only text shouldn't be affected at all sincereoderRTLis only called when RTL is detected.