-
-
Notifications
You must be signed in to change notification settings - Fork 447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add transparent overlay window #4746
base: master
Are you sure you want to change the base?
Conversation
I've been using https://github.com/baffler/Transparent-Twitch-Chat-Overlay for the functionality that this PR is going to add to Chatterino, very glad to see it finally happening. One major feature that is an oversight for many chat overlays is that it needs to have toggleable click-through, so that the widget can be sized and moved, but when toggled won't be able to be clicked or interfere with mouse pointer tracking in games and other programs. |
Windows only rn
* Align code style * Support multiple shortcuts
because git is slow or something
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
{"popupOverlay", | ||
[this](const auto &) -> QString { | ||
if (auto *page = dynamic_cast<SplitContainer *>( | ||
this->notebook_->getSelectedPage())) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
warning: redundant explicit casting to the same type 'SplitContainer *' as the sub-expression, remove this casting [readability-redundant-casting]
this->notebook_->getSelectedPage())) | |
if (auto *page = this->notebook_->getSelectedPage()) |
Additional context
src/widgets/Notebook.hpp:227: source type originates from the invocation of this method
SplitContainer *getSelectedPage();
^
Description
This PR adds a hotkey to open a transparent overlay channel-view. The colors of the overlay can be customized in the theme. To move, resize, and close the overlay, you have to press the SHIFT key.
TODO
This PR isn't fully done yet. Feedback on the implementation is welcome.
/watching
.ChannelView
s without aSplit
#4747)NCHITTEST
?Update theme migrations (wiki)Not needed as they will use a fallbackoverlayunderlay)firefox_2023-08-02_19-57-18.mp4
Link to the video in case the embed is broken:
https://github.com/Chatterino/chatterino2/assets/19953266/3e798169-a82f-4123-b834-7ce55daf0fc1
Closes #1618.