Fix XDG tests on Windows

[Nerixyz]

Description

• Fixes tests not compiling on Windows and macOS.
• Removes unused includes in XDG files (→ this should be done on Windows only code as well).

[pajlada]

Could we not just ifdef the tests out on Windows?

diff --git a/tests/src/XDGDesktopFile.cpp b/tests/src/XDGDesktopFile.cpp
index 171ac9f2..787cb947 100644
--- a/tests/src/XDGDesktopFile.cpp
+++ b/tests/src/XDGDesktopFile.cpp
@@ -5,6 +5,8 @@
 
 using namespace chatterino;
 
+#if defined(Q_OS_UNIX) and !defined(Q_OS_DARWIN)
+
 TEST(XDGDesktopFile, String)
 {
     auto desktopFile = XDGDesktopFile(":/001-mimeapps.list");
@@ -17,3 +19,5 @@ TEST(XDGDesktopFile, String)
 
     ASSERT_EQ(desktopFile.getEntries("test").size(), 2);
 }
+
+#endif
diff --git a/tests/src/XDGHelper.cpp b/tests/src/XDGHelper.cpp
index e142697b..580a45e8 100644
--- a/tests/src/XDGHelper.cpp
+++ b/tests/src/XDGHelper.cpp
@@ -5,6 +5,8 @@
 
 using namespace chatterino;
 
+#if defined(Q_OS_UNIX) and !defined(Q_OS_DARWIN)
+
 TEST(XDGHelper, ParseDesktopExecProgram)
 {
     struct TestCase {
@@ -60,3 +62,5 @@ TEST(XDGHelper, ParseDesktopExecProgram)
             << output.toStdString() << "'";
     }
 }
+
+#endif

[Nerixyz]

Could we not just ifdef the tests out on Windows and macOS?

Yes

[pajlada]

Undo the ifdef moves in the src/util/XDG*.* files, or change the ifdefs of all src/util/XDG*.* to consistently be

#include ...

#ifdef

namespace chatterino {
...
}

#endif

[Nerixyz]

Undo the ifdef moves in the src/util/XDG*.* files

I can't do that for the XDGDesktopFile.hpp file, because the chatterino namespace has to be known in the tests.