-
-
Notifications
You must be signed in to change notification settings - Fork 442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cmake flag to use system-provided miniaudio #4867
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just this one nit, change itself seems fine 👍
bfff64c
to
76d6e1b
Compare
changed message and added changelog |
152e796
to
3bcf961
Compare
Nits corrected |
Thank you! As a first-time contributor, you can now add yourself to the contributors list that's shown inside the About page in Chatterino. If you want this, you can open a new PR where you modify the |
Description
Allow to use system miniaudio for systems that provide it
This checks as well that the included file exists before including it from the system
If this is fine, i will as well add a cahngelog entry