Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cmake flag to use system-provided miniaudio #4867

Merged
merged 3 commits into from
Oct 4, 2023

Conversation

h3o66
Copy link
Contributor

@h3o66 h3o66 commented Oct 4, 2023

Description

Allow to use system miniaudio for systems that provide it
This checks as well that the included file exists before including it from the system

If this is fine, i will as well add a cahngelog entry

Copy link
Member

@pajlada pajlada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just this one nit, change itself seems fine 👍

src/CMakeLists.txt Outdated Show resolved Hide resolved
@h3o66
Copy link
Contributor Author

h3o66 commented Oct 4, 2023

changed message and added changelog

@h3o66 h3o66 marked this pull request as ready for review October 4, 2023 12:56
CHANGELOG.md Outdated Show resolved Hide resolved
CMakeLists.txt Outdated Show resolved Hide resolved
@h3o66
Copy link
Contributor Author

h3o66 commented Oct 4, 2023

Nits corrected

@pajlada pajlada changed the title Change to allow system miniaudio Add cmake flag to use system-provided miniaudio Oct 4, 2023
@pajlada pajlada enabled auto-merge (squash) October 4, 2023 13:17
@pajlada pajlada merged commit 5d5d265 into Chatterino:master Oct 4, 2023
15 checks passed
@h3o66 h3o66 deleted the miniaudio-system branch October 4, 2023 13:39
@pajlada
Copy link
Member

pajlada commented Oct 4, 2023

Thank you! As a first-time contributor, you can now add yourself to the contributors list that's shown inside the About page in Chatterino.

If you want this, you can open a new PR where you modify the resources/contributors.txt file and add yourself to the list. Make sure to read the comments at the top for instructions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants