Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add channel for messages caught by AutoMod #4986

Merged
merged 8 commits into from
Dec 3, 2023

Conversation

iProdigy
Copy link
Contributor

@iProdigy iProdigy commented Nov 27, 2023

Implements a split that shows automod caught messages across all channels the user moderates. Useful for folks that moderate multiple channels at once.

@pajlada pajlada self-requested a review November 27, 2023 21:26
@Nerixyz
Copy link
Contributor

Nerixyz commented Nov 27, 2023

This feels like something in the direction of #4931 - i.e. it could in the future contain more types of messages, for example some follower, prediction, poll, or similar feed.

Copy link
Member

@pajlada pajlada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code overall looks good to me, two things

  1. In the AutoMod logs, the message from automod doesn't have a channel attached to it
# Start logging at 2023-12-02 12:43:36 CET
# [12:43:36] automod: AutoMod: Held a message for reason: sexwords level 4. Allow will post it in chat. Allow Deny
#testaccount_420 [12:43:36] pajlada: pajlada: ...
  1. Global search shows messages from the automod channel - as you already outlined in the description

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

src/widgets/dialogs/SelectChannelDialog.cpp Show resolved Hide resolved
src/widgets/dialogs/SelectChannelDialog.cpp Show resolved Hide resolved
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

src/widgets/dialogs/SelectChannelDialog.cpp Show resolved Hide resolved
src/widgets/dialogs/SelectChannelDialog.cpp Show resolved Hide resolved
src/widgets/dialogs/SelectChannelDialog.cpp Show resolved Hide resolved
@pajlada
Copy link
Member

pajlada commented Dec 3, 2023

Confirmed the automod logs work as expected now, just gotta fix the global search.
Is that something you're comfortable trying out yourself?

@iProdigy
Copy link
Contributor Author

iProdigy commented Dec 3, 2023

Fixed global search for automod, but couldn't figure out how messages from mentionsChannel don't appear in global search without such a conditional...

edit: figured it out

// remove any duplicate messages from splits containing the same channel

@pajlada pajlada changed the title feat: add channel for automod caught messages feat: add channel for messages caught by AutoMod Dec 3, 2023
@pajlada pajlada enabled auto-merge (squash) December 3, 2023 21:49
@pajlada pajlada merged commit 44abe6b into Chatterino:master Dec 3, 2023
20 checks passed
@iProdigy iProdigy deleted the feature/automod-channel branch December 3, 2023 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants