Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing parent of tooltips for Wayland #4998

Merged
merged 4 commits into from
Dec 9, 2023

Conversation

crazysmc
Copy link
Contributor

@crazysmc crazysmc commented Dec 3, 2023

In response to issue #3501

Each widget that uses TooltipWidget gets its own instance of it with itself as a parent set.

That fixes the issue for me on Wayland. Although I'm not using a tiling WM, the parent-less tooltips appeared in the wrong place before.

Each widget that uses it gets its own instance of the TooltipWidget
@ilya-zlobintsev
Copy link
Contributor

This seems to solve the issue for me on Arch Linux using KDE 5.27. Tested on both QT5 and QT6.

@ilya-zlobintsev
Copy link
Contributor

I've also tested sway - the behaviour is slightly different, the previews don't show up at all when hovering over something when the window is unfocused, but IMO that is fine as well

@Nerixyz
Copy link
Contributor

Nerixyz commented Dec 5, 2023

Seems to work on Windows 10 with Qt 6. Works when the window is unfocused. Only thing I noticed is that tooltips will stay when the window is resized, but shouldn't be an issue.

@BKSalman
Copy link
Contributor

BKSalman commented Dec 6, 2023

tested on NixOS, it works using QT5

using this shell

nix-shell -p openssl boost qt5.full pkg-config cmake libsecret

Copy link
Member

@pajlada pajlada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Works as expected on Arch Linux w/ i3

As a first-time contributor, you can now add yourself to the contributors list that's shown inside the About page in Chatterino.

If you want this, you can open a new PR where you modify the resources/contributors.txt file and add yourself to the list. Make sure to read the comments at the top for instructions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants