-
-
Notifications
You must be signed in to change notification settings - Fork 442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added missing periods at mod-related messages and some system messages #5061
Added missing periods at mod-related messages and some system messages #5061
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be handled on a per-message basis rather than checked in the SystemMessage constructor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I should have been clearer in my initial feedback
The logic should be done where the message is actually created
As an example, the USERNAME has cleared the chat
message is created at https://github.com/Chatterino/chatterino2/blob/65b1ed3/src/Application.cpp#L346-L361 so you'd want to just add the period to that specific message instead of inside MessageBuilder at all.
Preferably, when we're done, MessageBuilder.cpp should not have any changes
…iods in various places.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small nitpicks, otherwise looks good! This is what I meant
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lastly, before this can be merged in, pull requests add a changelog entry in the CHANGELOG.md
file.
This is a minor change, so it should be added under the ## Unversioned
category among the other - Minor: ...
entries
A reasonable changelog entry for this change would be: - Minor: Added missing periods at various moderator messages and commands. (#5061)
, although you're free to reword it a bit as you see fit
Still missing periods on |
Slightly suboptimal since the . is part of the link now, but this is how it's done in other places
Slightly suboptimal since the . is part of the link now, but this is how it's done in other places
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I fixed the /ban
, /untimeout
, and /unban
responses now. They did have to be changed in their respective MessageBuilder.cpp
code.
Thank you for your contribution!
Thank you! As a first-time contributor, you can now add yourself to the contributors list that's shown inside the About page in Chatterino. If you want this, you can open a new PR where you modify the |
Fixes #4515