-
-
Notifications
You must be signed in to change notification settings - Fork 442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: resolve /live channel liveness using their channel ID #5172
Conversation
changelog.md entry |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to work as expected, so far 3 of my channels loaded before displayName capitalization was obtained, have correctly been greyed-out in the /live
tab when they went offline
Thanks for the review. Should I add a commit with the changelog entry? |
if you want, otherwise pajlada will do it on the weekend (and maybe move my comma) |
Added a commit because QString::compare returns 0 when the strings are equal |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Little bit hard to test but it seems to work as expected - thank you!
Thank you! As a first-time contributor, you can now add yourself to the contributors list that's shown inside the About page in Chatterino. If you want this, you can open a new PR where you modify the |
This fix for #5158 uses the
TwitchChannel
roomId()
as the message id when sending live messages (TwitchMessageBuilder::liveMessage
andTwitchMessageBuilder::liveSystemMessage
). I wasn't able to replicate the same logic for live messages sent throughNotificationController
(I couldn't find a way to access theTwitchChannel
from there), so I went with the other option of using a case insensitive string compare. I accept any ideas on how I could do this better, especially theNotificationController
bit.(felanbird): Fixes #5158